Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: store setTimeout locally in case it was overriden #7

Merged
merged 2 commits into from
Apr 6, 2023
Merged

fix: store setTimeout locally in case it was overriden #7

merged 2 commits into from
Apr 6, 2023

Conversation

sheremet-va
Copy link
Collaborator

@sheremet-va sheremet-va commented Apr 5, 2023 •
edited
Loading

Description

This PR stores setTimeout locally in case it was overridden later by a mocked one.

Linked Issues

None.

Additional context

This is needed, so we can remove the ugly Proxy in Vitest that stopped working after birpc allowed async on.

Alternative

We can also take setTimeout from globalThis in the module context

@sheremet-va sheremet-va changed the title feat: allow custom setTimeout implementation fix: store setTimeout locally Apr 5, 2023
@sheremet-va sheremet-va changed the title fix: store setTimeout locally fix: store setTimeout locally in case it was overriden Apr 5, 2023
@antfu antfu merged commit cb32d43 into antfu:main Apr 6, 2023
@sheremet-va sheremet-va deleted the feat/add-set-timeout branch April 6, 2023 07:32
@AriPerkkio AriPerkkio mentioned this pull request Sep 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheremet-va @antfu