Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: waterfall view #118

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Conversation

KermanX
Copy link

@KermanX KermanX commented Aug 11, 2024

Waterfall/timeline view. Feedback welcome.

image

@KermanX KermanX marked this pull request as draft August 11, 2024 16:21
@KermanX KermanX changed the title feat: waterfall feat: waterfall view Aug 11, 2024
@KermanX KermanX marked this pull request as ready for review August 12, 2024 08:04
@antfu
Copy link
Member

antfu commented Aug 20, 2024

Can we colorize each type, and also provide a hover dialog for each item? It's a bit tricky to understand how it represents right now.

The latest commit should contains floating vue and some color utilities

@ArthurDarkstone
Copy link

image

accomplished based on 'vis-timeline', but there are some limitations. Maybe 'echarts' should be used instead

@ArthurDarkstone
Copy link

ArthurDarkstone commented Sep 18, 2024

image

colorized, add tooltips

yAxis: {
data: categories.value,
} satisfies SingleAxisComponentOption,
series: [
Copy link

@ArthurDarkstone ArthurDarkstone Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group by id or plugin name ?

@ArthurDarkstone
Copy link

maybe should add the following period segmentation, otherwise its need to zoom to the millisecond level to see the ‘<1ms’ block

@KermanX KermanX marked this pull request as draft December 17, 2024 03:57
@KermanX
Copy link
Author

KermanX commented Dec 17, 2024

It seems that we should render the first load and each HMR separately. Otherwise, the time span is too long, which makes everything hard to see.

@ArthurDarkstone
Copy link

It seems that we should render the first load and each HMR separately. Otherwise, the time span is too long, which makes everything hard to see.

indeed, and maybe should added more filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants