fix: --exec ENOENT tinyexec args, close #62 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
antfu
reviewed
Dec 11, 2024
src/version-bump.ts
Outdated
| @@ -77,9 +77,11 @@ export async function versionBump(arg: (VersionBumpOptions) | string = {}): Prom | |||
| } | |||
| else { | |||
| console.log(symbols.info, 'Executing script', operation.options.execute) | |||
| await x(operation.options.execute, [], { | |||
| const [command, ...args] = operation.options.execute.split(' ') | |||
There was a problem hiding this comment.
Well, this is honestly tricky as this would usually need a proper parser to handle cases like -m "some space in side". It's a shame the tinyexec doesn't support the command mode. Maybe we find a library for this?
There was a problem hiding this comment.
execa supports the command mode.
Are there any other recommended libraries?
There was a problem hiding this comment.
I brought it upstream: tinylibs/tinyexec#42
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--exec="command"will throw errorENOENT.Caused by this commit: 780b7cc#diff-98dd85fb32fd9de446227ad9d0c91df2a4f8ec1d1436b6b294ec11413bf3a0e7R80
Linked Issues
#62
Additional context
Add
exec.test.tsto test--exec.