Improve number handling by returning NaN for non-numbers #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing unknown documents, fields that should contain numbers might, for whatever reason, actually contain e.g. a string. In this case the current implementation is also a bit inconsistent and will return a
float64(0)
when performing anumber(//some_string_field)
query and will panic if executed on a string. The latter might happen if the query is constructed prgramatically.The present PR changes the behavior such that the above query will return
math.NaN()
and leaves the value handling to the caller. If required, the previous behavior can be reconstructed inceil
,floor
etc which will now also returnNaN
s.