Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General API cleanup suggestions #34

Closed
ojw28 opened this issue May 8, 2017 · 2 comments
Closed

General API cleanup suggestions #34

ojw28 opened this issue May 8, 2017 · 2 comments

Comments

@ojw28
Copy link

ojw28 commented May 8, 2017

  • close() could return void. There's no value to the return value if it's always the same.
  • isConnected could more clearly return a boolean instead of an integer.
  • It's unclear from the Javadoc what the return values are for seek and pause.
@mekya mekya mentioned this issue May 9, 2017
Merged
mekya added a commit that referenced this issue Jun 13, 2017
@mekya
Make isConnected and pause functions return boolean #34
14e126d
mekya added a commit that referenced this issue Jun 13, 2017
@mekya
Make isConnected and pause functions return boolean #34
7c64717
@mekya
Copy link
Contributor

mekya commented Jun 13, 2017

Please check the the commits referenced above @ojw28

@ojw28
Copy link
Author

ojw28 commented Jun 13, 2017

Thanks. Looking good! I posted a few comments here: 14e126d.

@ojw28 ojw28 closed this as completed Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mekya @ojw28