Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward auto start request to origin #6730

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

lastpeony
Copy link
Contributor

Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lastpeony ,

Thank you for the fix.

I've some comments and request changes.

Lastly, a cluster integration test will be great to confirm that it's working.

Let me know if you have other ideas or questions.

src/main/java/io/antmedia/AntMediaApplicationAdapter.java Outdated Show resolved Hide resolved
src/main/java/io/antmedia/AntMediaApplicationAdapter.java Outdated Show resolved Hide resolved
src/main/java/io/antmedia/AntMediaApplicationAdapter.java Outdated Show resolved Hide resolved
src/main/java/io/antmedia/AntMediaApplicationAdapter.java Outdated Show resolved Hide resolved
@lastpeony
Copy link
Contributor Author

lastpeony commented Nov 18, 2024

Hi @lastpeony ,

Thank you for the fix.

I've some comments and request changes.

Lastly, a cluster integration test will be great to confirm that it's working.

Let me know if you have other ideas or questions.

Hello @mekya
Thank you for the review. I will check those and do the changes accordingly.
There is a cluster integration test on gitlab

https://gitlab.com/Ant-Media/testcluster/-/merge_requests/99

Copy link

sonarcloud bot commented Nov 18, 2024

@lastpeony lastpeony requested a review from mekya November 19, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants