-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add docs deploy workflow #91
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 92.18% 92.63% +0.44%
==========================================
Files 18 19 +1
Lines 576 611 +35
Branches 192 201 +9
==========================================
+ Hits 531 566 +35
Misses 45 45
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
.dumirc.ts
Outdated
const basePath = process.env.GITHUB_ACTIONS ? '/cssinjs/' : '/'; | ||
const publicPath = process.env.GITHUB_ACTIONS ? '/cssinjs/' : '/'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不用判断 env,直接加上就好
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
开发者本地构建后。 preview 可能有问题。我需要验证一下。cc @PeachScript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我需要验证一下
验证了一下,本地构建后想 preview 会有问题。个人建议还是保留~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以参考一下 rc-mentions 的 preview 部署
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我需要验证一下
验证了一下,本地构建后想 preview 会有问题。个人建议还是保留~
这样本地构建推上去是不对的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以参考一下 rc-mentions 的 preview 部署
好滴~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/react-component/mentions/blob/master/.dumirc.ts#L14-L15 是指这里的逻辑么? 本地构建后错误的。是不是和 dumi 版本有关系。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
说错了,看 color-picker 吧,https://github.com/react-component/color-picker/blob/master/.dumirc.ts#L4
preview 构建加环境变量
This reverts commit 8f78f24.
.dumirc.ts
Outdated
const name = 'cssinjs'; | ||
|
||
const isDeployGitHubPage = [ | ||
process.env.GH_PAGE, | ||
process.env.GITHUB_ACTIONS, | ||
].includes('true'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我感觉这样好理解一点,就判断是不是要部署到 GitHub Page 就好了, 有其他考量么 ? @MadCcc
冲突 |
将部署任务交由 GitHub Action 处理。解放本地机器。支持 tag 创建触发 + 手动触发