Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add docs deploy workflow #91

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Wxh16144
Copy link
Member

将部署任务交由 GitHub Action 处理。解放本地机器。支持 tag 创建触发 + 手动触发

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.44 🎉

Comparison is base (f9826f3) 92.18% compared to head (398ba27) 92.63%.

❗ Current head 398ba27 differs from pull request most recent head dbf5367. Consider uploading reports for the commit dbf5367 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   92.18%   92.63%   +0.44%     
==========================================
  Files          18       19       +1     
  Lines         576      611      +35     
  Branches      192      201       +9     
==========================================
+ Hits          531      566      +35     
  Misses         45       45              
Impacted Files Coverage Δ
src/transformers/legacyLogicalProperties.ts 96.72% <100.00%> (+0.42%) ⬆️
src/transformers/px2rem.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

package.json Show resolved Hide resolved
.dumirc.ts Outdated
Comment on lines 4 to 5
const basePath = process.env.GITHUB_ACTIONS ? '/cssinjs/' : '/';
const publicPath = process.env.GITHUB_ACTIONS ? '/cssinjs/' : '/';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用判断 env,直接加上就好

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

开发者本地构建后。 preview 可能有问题。我需要验证一下。cc @PeachScript

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我需要验证一下

验证了一下,本地构建后想 preview 会有问题。个人建议还是保留~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以参考一下 rc-mentions 的 preview 部署

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我需要验证一下

验证了一下,本地构建后想 preview 会有问题。个人建议还是保留~

这样本地构建推上去是不对的

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以参考一下 rc-mentions 的 preview 部署

好滴~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/react-component/mentions/blob/master/.dumirc.ts#L14-L15 是指这里的逻辑么? 本地构建后错误的。是不是和 dumi 版本有关系。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

说错了,看 color-picker 吧,https://github.com/react-component/color-picker/blob/master/.dumirc.ts#L4
preview 构建加环境变量

.dumirc.ts Outdated
Comment on lines 4 to 9
const name = 'cssinjs';

const isDeployGitHubPage = [
process.env.GH_PAGE,
process.env.GITHUB_ACTIONS,
].includes('true');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我感觉这样好理解一点,就判断是不是要部署到 GitHub Page 就好了, 有其他考量么 ? @MadCcc

@afc163
Copy link
Member

afc163 commented Jul 5, 2023

冲突

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants