-
-
Notifications
You must be signed in to change notification settings - Fork 50k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form): improve scrollToField logic #48211
feat(form): improve scrollToField logic #48211
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #48211 Passed ✅
🎊 Congrats! No visual-regression diff found. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #48211 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 744 744
Lines 12896 12903 +7
Branches 3382 3384 +2
=========================================
+ Hits 12896 12903 +7 ☔ View full report in Codecov by Sentry. |
fa816cd
to
e244b93
Compare
Co-authored-by: afc163 <[email protected]> Signed-off-by: 红 <[email protected]>
Co-authored-by: lijianan <[email protected]> Signed-off-by: 红 <[email protected]>
3180443
to
85e12ff
Compare
这个是真做不了, 直接推荐用 |
rebase 一下 feature,看看 ci 会不会过。 |
看起来没啥问题,可以 merge 了~ |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
改进表单 scrollToField 方法逻辑 ,优先从 item Ref 中获取元素,等待 #48210 合并后可以 close #28869
解决方案讨论 ref:#45410 (comment)
📝 Changelog
☑️ Self-Check before Merge