Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy code for hash jump #44836

Merged
merged 1 commit into from
Sep 13, 2023
Merged

chore: remove legacy code for hash jump #44836

merged 1 commit into from
Sep 13, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 13, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 649a224

Refactored DocLayout component to improve performance and readability. Removed unused code and simplified scroll and analytics logic for documentation pages.

🔍 Walkthrough

🤖 Generated by Copilot at 649a224

  • Remove unused imports and variables from DocLayout component (link, link)
  • Simplify scroll behavior and remove Baidu analytics tracking from DocLayout component (link)

@stackblitz
Copy link

stackblitz bot commented Sep 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 393.78 KB
./dist/antd-with-locales.min.js 452.96 KB

@argos-ci
Copy link

argos-ci bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 13, 2023, 10:27 AM

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2387091) 100.00% compared to head (649a224) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44836   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          682       682           
  Lines        11538     11538           
  Branches      3104      3104           
=========================================
  Hits         11538     11538           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 marked this pull request as ready for review September 13, 2023 11:08
@afc163 afc163 merged commit 72da267 into master Sep 13, 2023
95 checks passed
@afc163 afc163 deleted the chore/fix-hash-jump branch September 13, 2023 11:08
Wxh16144 added a commit to Wxh16144-forks/ant-design that referenced this pull request Oct 10, 2023
afc163 added a commit that referenced this pull request Oct 10, 2023
* chore: fix typo error

* chore: fix anchor jump failure

* Revert "chore: fix anchor jump failure"

This reverts commit 9a11273.

* chore: fix

* Revert "chore: fix"

This reverts commit 9dc69f1.

* Revert "site: remove legacy code for hash jump (#44836)"

This reverts commit 72da267.

* chore: remove

* Update .dumi/theme/layouts/DocLayout/index.tsx

Co-authored-by: afc163 <[email protected]>
Signed-off-by: 红 <[email protected]>

* chore: update

---------

Signed-off-by: 红 <[email protected]>
Co-authored-by: afc163 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants