Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Descriptions size small of CP #42244

Merged
merged 1 commit into from
May 10, 2023

Conversation

wanghui2021
Copy link
Contributor

@wanghui2021 wanghui2021 commented May 10, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix ConfigProvider size prop not work on Descriptions.
🇨🇳 Chinese 修复 ConfigProvider size 对 Descriptions 无效的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 17ad002

Added support for componentSize from ConfigProvider to Descriptions component. Renamed size prop to customizeSize and updated tests accordingly.

🔍 Walkthrough

🤖 Generated by Copilot at 17ad002

  • Rename size prop of Descriptions component to customizeSize and use SizeContext to get componentSize value from ConfigProvider (link, link, link, link)
  • Add ConfigProvider component to test file and create a new test case to check that Descriptions component inherits size from ConfigProvider (link, link)

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1a44c46) 100.00% compared to head (17ad002) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42244   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          618       618           
  Lines        10539     10541    +2     
  Branches      2879      2880    +1     
=========================================
+ Hits         10539     10541    +2     
Impacted Files Coverage Δ
components/descriptions/index.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit d0e29d3 into ant-design:master May 10, 2023
@wanghui2021 wanghui2021 deleted the descriptions-small branch May 10, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants