Add upgrade warning #4028
Merged
Add upgrade warning #4028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjycui, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yiminghe, @afc163 and @waywardmonkeys to be potential reviewers. |
afc163
reviewed
Nov 28, 2016
| 'The value/defaultValue of Calendar must be a moment object after `[email protected]`, ' + | ||
| 'see: http://u.ant.design/jI6pSlR' | ||
| ); | ||
| } |
There was a problem hiding this comment.
主要是觉得，配个 demo 的链接比较好。
afc163
reviewed
Nov 28, 2016
| if (!(value instanceof moment)) { | ||
| throw new Error( | ||
| 'The value/defaultValue of Calendar must be a moment object after `[email protected]`, ' + | ||
| 'see: http://u.ant.design/jI6pSlR' |
There was a problem hiding this comment.
我的意思是 antd 这里不要用自动生成的随机域名，手动维护一个可读的域名。
There was a problem hiding this comment.
试了下。。 demo 的 URL 如果要提供一个语义化的链接，还是挺长的。。
There was a problem hiding this comment.
长短其实没关系，主要是提供一个固定的快捷域名，以后真实域名变化，用户旧代码也不受影响。
benjycui
force-pushed
the
upgrade-warning
branch
from
6fa1adb
to
4233844
Compare
|
Changes Unknown when pulling 4233844 on upgrade-warning into ** on master**. |
|
Changes Unknown when pulling 4233844 on upgrade-warning into ** on master**. |
|
2.0 breaking changes 里面，能加 warning 的都加了 warning，并增加链接到 demo |
benjycui
force-pushed
the
upgrade-warning
branch
from
4233844
to
85e870b
Compare
|
Updated. |
|
rebase |
benjycui
force-pushed
the
upgrade-warning
branch
from
ba7cde0
to
25a19b2
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.