Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Steps inside Steps style #27514

Merged
merged 3 commits into from
Nov 3, 2020
Merged

fix: Steps inside Steps style #27514

merged 3 commits into from
Nov 3, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 3, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Steps style that inside another Steps.
🇨🇳 Chinese 修复 Steps 内嵌 Steps 时的样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/steps/demo/steps-in-steps.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 3, 2020

.@{steps-prefix-cls}-rtl.@{steps-prefix-cls}-horizontal.@{steps-prefix-cls}-label-horizontal {
// https://github.com/ant-design/ant-design/issues/27498
.@{steps-prefix-cls}-item {
padding-left: 0 !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left right ?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2020

Size Change: +53 B (0%)

Total Size: 791 kB

Filename Size Change
./dist/antd.compact.min.css 66.6 kB +16 B (0%)
./dist/antd.dark.min.css 67.9 kB +20 B (0%)
./dist/antd.min.css 66.6 kB +17 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 313 kB 0 B
./dist/antd.min.js 277 kB 0 B

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1626446:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #27514 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27514   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7404      7404           
  Branches      2038      2080   +42     
=========================================
  Hits          7404      7404           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62fa37d...1626446. Read the comment docs.

@afc163 afc163 merged commit 114dde6 into master Nov 3, 2020
@afc163 afc163 deleted the fix-steps-styles branch November 3, 2020 08:20
headwindz pushed a commit to headwindz/ant-design that referenced this pull request Nov 4, 2020
* style: fix style of Steps inside Steps

* fix snapshot and rtl

* fix rtl style
@afc163 afc163 mentioned this pull request Nov 8, 2020
@xrkffgg xrkffgg mentioned this pull request Nov 25, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants