feat: Add test code into the getQrCodeLink method to skip throw error & remove mock #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
这个不要删，后面还是有用的，可以用于 UI 组件单测
| @@ -73,7 +73,15 @@ export class UniversalProvider extends EventEmitter implements UniversalWeb3Prov | |||
| } | |||
|
|
|||
| getQrCodeLink(): Promise<string> { | |||
| throw new Error('Method not implemented.'); | |||
| return new Promise<string>((resolve) => | |||
| setTimeout( | |||
There was a problem hiding this comment.
这个 Provider 还是不要用 mock 代码，要具体实现下。getQrCodeLink 这个逻辑可能要再仔细看看怎么设计。这个二维码是要通过 WallectConnect 的 Provider 获取的，要看看怎么搞。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.