-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bitcoin): Add phantom wallet adapter #1267
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d51fcfc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: thinkasany <[email protected]>
看到这个 psbt 想到一个问题,钱包更关心的是如何发起一笔交易,其中的 psbt 数据应该是不感知的。 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 858 859 +1
Lines 14726 14729 +3
Branches 1589 1589
=======================================
+ Hits 14725 14728 +3
Misses 1 1 ☔ View full report in Codecov by Sentry. |
有冲突了 |
# Conflicts: # pnpm-lock.yaml
报错是 vitest 里面有类型不匹配,没看明白怎么改 |
我看你改了 lock 文件,不要改呢?把和这个 PR 无关的内容先去掉。 另外升级下 pnpm 到 9 |
pr 新增了一个依赖,好像避免不了 lock 文件的变动。 |
看上去 CI 的报错就和你加的依赖有关:
|
升级到 pnpm@9 之后再重新添加下依赖试试呢? |
我本地的 pnpm 已经是最新的了。
这个错误是由于另一个依赖 sats-connect 变更导致的: #1274 |
添加 Phantom Wallet 的 比特币钱包适配器。
Phantom 的文档见:https://docs.phantom.app/bitcoin/integrating-phantom
注:
sendTransfer
或类似方法,所以修改了BitcoinWallet
接口;broadcast
选项;uint8array-tools
依赖,用于对 Uint8Array 值做转换;💡 Background and solution
🔗 Related issue link