Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Tron #1258

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

feat: Add support for Tron #1258

wants to merge 10 commits into from

Conversation

Likang0122
Copy link
Collaborator

[中文版模板 / Chinese template]

💡 Background and solution

Add support for Tron

🔗 Related issue link

#1051

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ❌ Failed (Inspect) Dec 3, 2024 7:04am

Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: 7e411fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ant-design/web3-tron Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented Nov 21, 2024

Preview Failed

Copy link

socket-security bot commented Nov 21, 2024

@@ -0,0 +1,38 @@
import React, { useState } from 'react';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件夹下两个组件的大小写不一致,统一为大驼峰吧

@@ -0,0 +1 @@
# @ant-design/web3-tron
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme 简单写一个

@@ -0,0 +1,67 @@
{
"name": "@ant-design/web3-tron",
"version": "1.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改为 0.0.1,新增一个 changlog,然后发布的时候就会发布为 1.0.0 版本

export * from './provider';
export * from './wallets/types';
export * from './wallets/okxTronWallet';
export { useWallet } from '@tronweb3/tronwallet-adapter-react-hooks';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个里面都有些什么 hooks?如果是我们依赖了 @tronweb3/tronwallet-adapter-react-hooks 这个,但是又需要暴露给用户用,是不是把 @tronweb3/tronwallet-adapter-react-hooks 中的内容全部通过 @ant-design/web3-tron/hooks 暴露出去?

可以讨论一下。

@@ -0,0 +1,14 @@
import { ConnectButton, Connector } from '@ant-design/web3';
import { okxTronWallet, tronWallets, TronWeb3ConfigProvider } from '@ant-design/web3-tron';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tronWallets 是复数?

<code src='./demos/message.tsx'></code>

## Sign Transaction

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档 API 补充一下

@github-actions github-actions bot added the major label Nov 26, 2024
Copy link

github-actions bot commented Nov 26, 2024

🚨 @Likang0122, 本次 PR 的更改包含 major 变更,请确认是否符合预期。


🚨 @Likang0122, this PR contains major changes, please confirm if it is as expected.

+'@ant-design/web3-tron': major

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants