Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug input editable #78

Merged
merged 1 commit into from
Oct 20, 2018
Merged

Conversation

DavidNorena
Copy link
Contributor

Hi guys input property editable was not working 👍 this is a little fix.

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

isBugFix :

  • [] Make sure that you add at least one unit test for the bug which you had fixed.

@tmmgn
Copy link

tmmgn commented Aug 8, 2018

Please accept this pr cause its really important

@DavidNorena
Copy link
Contributor Author

inside package.json this command "antd-tools run tsc" it's giving a lot of third party @types errors, that's why travis build it's failing, but this change its really important for me too :(

@BANG88 BANG88 merged commit c0c6c31 into ant-design:master Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants