Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: popover fixes #285 #298

Merged
merged 4 commits into from
Jan 26, 2019
Merged

refactor: popover fixes #285 #298

merged 4 commits into from
Jan 26, 2019

Conversation

BANG88
Copy link
Member

@BANG88 BANG88 commented Jan 26, 2019

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@codecov
Copy link

codecov bot commented Jan 26, 2019

Codecov Report

Merging #298 into master will decrease coverage by 0.06%.
The diff coverage is 71.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   59.23%   59.17%   -0.07%     
==========================================
  Files         197      197              
  Lines        4958     4977      +19     
  Branches     1087     1090       +3     
==========================================
+ Hits         2937     2945       +8     
- Misses       2004     2015      +11     
  Partials       17       17
Flag Coverage Δ
#rn 59.17% <71.79%> (-0.07%) ⬇️
Impacted Files Coverage Δ
components/popover/demo/basic.tsx 86.95% <71.42%> (-7.79%) ⬇️
components/popover/index.tsx 72.97% <71.87%> (-22.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab1f26...683d99b. Read the comment docs.

@BANG88 BANG88 merged commit 33ac452 into master Jan 26, 2019
@BANG88 BANG88 deleted the popover branch January 26, 2019 09:18
GrigoryPtashko added a commit to GrigoryPtashko/ant-design-mobile-rn that referenced this pull request Jul 23, 2019
* upstream/master:
  bump
  fix DatePicker styles prop covering the context styles of WithTheme (ant-design#566)
  chore(deps-dev): bump eslint from 4.3.0 to 4.18.2
  Modal动画销毁前停止动画 (ant-design#554)
  fixes ant-design#536
  bump
  修改文档使用expo sdk32以上版本时出现的问题 (ant-design#535)
  SegmentedControl comonent selected segment  text bug in android (ant-design#520)
  bump
  refactor: toast allow fullscreen fixes ant-design#434
  bump
  feat: checkbox read color from theme fixes ant-design#416
  bump
  fix ant-design#412 and picker demo (ant-design#459)
  doc: remove qrcode
  fix: demo of picker
  bump
  use call fn to invoke scollView's scrollTo (ant-design#408) fix: ant-design#403
  bump
  fix: swipeable not work with android fixes: ant-design#380
  feat: 为Card组件的HeaderContent和HeaderExtra添加Wrap style,便于定制 fixes ant-design#395
  fix: demo of picker
  feat: add demo-data pkg
  fix: demo
  fix: link of date-picker close ant-design#379
  fix: demo of picker
  chore: add support
  chore: add ga
  bump
  fix: ant-design#344
  fix: add babel-runtime fixes ant-design#346 ant-design#309
  bump
  fix: spread SwipeAction rest props (ant-design#318)
  bump
  feat(popover): add placement prop fixes ant-design#308
  bump
  fix: popover on android
  refactor: popover fixes ant-design#285 (ant-design#298)
  update snap
  fix: input-item style ant-design#279
  bump
  fix: tabbar not updated fixes ant-design#201
  test: update snap
  fix: demo
  fix: groupTypes is not supported on Android fixes ant-design#264
  bump
  doc: changelog
  test: update snaps
  fix: make InputItem clear icon behave properly in Android  close ant-design#248
  fix: ant-design#249
  refactor: input height  fixes ant-design#249
  fix search-bar icon size (ant-design#250)
  bump
  doc: changelog of 3.0.4
  fix: remove react native require cycle warning close ant-design#236
  fixes ant-design#233
  fix SwipeAction props type defination about left and right (ant-design#230)
  Segmented control tintcolor (ant-design#211)
  修改SegmentedControl默认颜色为主题颜色
  doc: fixes ant-design#164
  fix: tabBarUnderlineStyle fixes ant-design#174
  3.0.3
  feat: tabs title support custom React.Element
  fix ListView loadmore issue with paginationAllLoadedView
  feat: tabs add renderUnderline
  add renderTab prop-type of tabs.
  site: add doc about list-view
  3.0.2
  site: toast doc
  test: update snap
  feat: add Locale definition
  fix: typescript errors
  site: provider
  typo
  fix: typo
  fix: typo
  site: docs
  site: notes
  site: 2.x
  doc: expo
  site: update notes
  feat: add dynamic theme example
  fix: Modal static property has type of any
  fix: alert's content can be a view element
  3.0.1
  remove: resolutions
  fix: scripts
  site: example
  site: notes
  doc: changelog
  chore: remove unused package
  3.0.0
  site: list-view
  fix: jest
  3.0.0-17
  site: fix examples
  fix: miss mock file
  chore: jest
  site: tab-bar
  3.0.0-16
  fix: tests
  feat: add safe area view for tab-bar
  refactor: tab-bar support custom icon close ant-design#158
  chore: code style
  fix: picker value type always string close ant-design#68
  feat: add textAreaRef close ant-design#141
  feat: ImagePicker performance enhancement close ant-design#45
  fix: type definition
  feat: add cameraPickerProps close ant-design#94
  feat: add locale
  update snap
  feat: add list-view
  fix: incorrect container width close ant-design#162
  fix: button with activeStyle
  fix: Portal imports
  feat: exports Portal
  fix: ImagePicker example
  fix: type definition
  fix: renderUnderline close ant-design#96
  3.0.0-15
  chore: ignore demos
  3.0.0-14
  feat: support item style close ant-design#54
  chore: update snap
  feat: support use12hours close ant-design#151
  fix: item style
  refactor: remove unused props
  chore: code style
  chore: add demo for picker
  fix: picker on android close ant-design#117
  refactor: picker
  fix: allow overwrite activeOpacity close ant-design#133
  feat: add renderIcon for steps close ant-design#136
  fix: tabs position
  fix: add disabled property close ant-design#149
  fix: locale example
  fix: modal and toast examples
  site: icon
  site: add example
  site: add icon fonts
  doc: update examples
  3.0.0-13
  fix: tabs onChange on android
  fix: notice-bar tests
  fix: search-bar tests
  fix: button tests
  fix: tag tests
  chore: decrease duration
  fix: notice-bar icon
  feat: partial Theme
  chore: update snap
  fix: demo
  chore: export provider
  3.0.0-7
  chore: update deps
  test: update snap
  feat: exports Portal
  refactor: locale-provider
  refactor: picker ant-design#154
  refactor: date-picker ant-design#154
  refactor: tabs ant-design#154
  refactor: list modal notice-bar pagination ant-design#154
  refactor: input item ant-design#154
  chore: add privacy for camera picker
  refactor: image-picker close ant-design#42
  fix: example
  refactor: grid icon ant-design#154
  refactor: styles ant-design#154
  refactor: segmented-control ant-design#154
  refactor: slider ant-design#154
  refactor: stepper
  fix: miss
  refactor: steps ant-design#154
  refactor: tab-bar ant-design#154
  refactor: styles ant-design#154
  test: update snap
  refactor: checkbox ant-design#154
  refactor: carousel ant-design#154
  test: button
  test: update snap
  refactor: card ant-design#154
  refactor: badge ant-design#154
  refactor: activity-indicator ant-design#154
  refactor: action-sheet  ant-design#154
  refactor: accordion ant-design#154
  refactor(button): use theme context
  chore: site
  chore: include vscode configurations
  test: update snap
  3.0.0-6
  chore: update icon
  style: full screen button
  feat: add sandbox
  refactor(modal): use portal close ant-design#79
  refactor(swipe-action): use react-native-swipeout directly
  doc: support me please
  fix: initialPage not work correctly on android side close ant-design#50
  refactor: tabs
  fix: typo
  fix: optional styles prop close ant-design#30
  fix: ts type close ant-design#80
  fix: app crashes when message is empty close ant-design#99
  test: update snap
  feat: performance improvements close ant-design#128
  refactor: remove top-view instead of portal
  refactor: remove images
  fix: font size
  refactor: radio ant-design#140
  chore: clean images ant-design#140
  tests: update snap
  refactor: toast ant-design#140
  refactor: replace image with icon ant-design#140
  chore: clean
  refactor: tabs
  chore: hooks
  refactor(icon): use @ant-design/icons-react-native ant-design#140
  fix: lint
  feat: exports props wip
  fix: tests
  chore: use locale
  feat: give react hooks a try
  fix: fonts on android
  feat: add fonts
  feat: portal
  fix components docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant