Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #233 #234

Merged
merged 1 commit into from
Dec 28, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.en-US.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ toc: false
- We can preview our Components online using codesandbox and react-native-web
- Refactor Icon Component and use [ant-design-icons](https://github.com/ant-design/ant-design-icons/tree/master/packages/icons-react-native) instead
- `Toast` has removed method `hide`
- Change `Grid` property `onClick` to `onPress`
- Upgrade from 2.x to 3.0.0 please checkout [upgrade notes](https://rn.mobile.ant.design/docs/react/upgrade-notes)

### 2.3.0
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.zh-CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ toc: false
- 完善文档,使用 codesandbox 以及 react-native-web 提供部分组件在线预览
- 重构 Icon 组件,现在使用 [ant-design-icons](https://github.com/ant-design/ant-design-icons/tree/master/packages/icons-react-native)
- Toast 移除了 `hide` 方法
- 修改`Grid`的`onClick`属性为`onPress`
- 更多组件优化以及使用方式请查看文档
- 从 2.x 升级到 3.0.0 请查看[upgrade notes](https://rn.mobile.ant.design/docs/react/upgrade-notes-cn)

Expand Down
2 changes: 1 addition & 1 deletion components/grid/index.en-US.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ We divided the design area into a number of aliquots in horizontal and vertical.
| Properties | Description | Type | Default |
| -------------- | ------------------------------------------------------------- | --------------------------------- | ----------- |
| data | data record array to be rendered | `Array<{icon, text}>` | [] |
| onClick | Handler to be called when the user taps the grid | (el: Object, index: number): void | - |
| onPress | Handler to be called when the user taps the grid | (el: Object, index: number): void | - |
| columnNum | the number of columns | number | `4` |
| hasLine | whether to show border | boolean | `true` |
| isCarousel | whether to be played as a Carousel | boolean | `false` |
Expand Down
2 changes: 1 addition & 1 deletion components/grid/index.zh-CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ subtitle: 宫格
| 属性 | 说明 | 类型 | 默认值 |
| -------------- | -------------------------------------- | --------------------------------- | ----------- |
| data | 传入的菜单数据 | `Array<{icon, text}>` | [] |
| onClick | 点击每个菜单的回调函数 | (el: Object, index: number): void | - |
| onPress | 点击每个菜单的回调函数 | (el: Object, index: number): void | - |
| columnNum | 列数 | number | `4` |
| hasLine | 是否有边框 | boolean | `true` |
| isCarousel | 是否跑马灯, | boolean | `false` |
Expand Down
1 change: 1 addition & 0 deletions docs/react/upgrade-notes.en-US.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Here list some of main incompatible changes and recommended changes in the upgra
   - Override local component styles by using styles of the component, without importing all styles of the current component
   - There is no need to import a theme style file like 2.x. The current style file returns a function instead of an object.
- `Toast` has removed method `hide`
- Change `Grid` property `onClick` to `onPress`
- Link Icon Fonts

```sh
Expand Down
1 change: 1 addition & 0 deletions docs/react/upgrade-notes.zh-CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ title: 升级指南
- 通过组件的 styles 覆盖局部组件样式,不需要导入当前组件的所有样式
- 不需要像 2.x 那样导入一个样式文件,现在的样式文件返回的是一个 function 而不是一个对象了
- Toast 移除了 `hide` 方法
- 修改`Grid`的`onClick`属性为`onPress`
- Link Icon Fonts

```sh
Expand Down