Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type error on React 18 #1257

Merged
merged 1 commit into from
Oct 8, 2022
Merged

fix: type error on React 18 #1257

merged 1 commit into from
Oct 8, 2022

Conversation

lhr000lhr
Copy link
Contributor

@lhr000lhr lhr000lhr commented Sep 15, 2022

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@1uokun
Copy link
Collaborator

1uokun commented Sep 15, 2022

<WhiteSpace>、包括还有其他组件 可以也帮忙补充一下吗,栓Q🥰

@lhr000lhr
Copy link
Contributor Author

sure thing.

@lhr000lhr lhr000lhr changed the title fix(WingBlank): type error on React 18 fix: type error on React 18 Oct 6, 2022
@lhr000lhr
Copy link
Contributor Author

@1uokun Could u review this PR?

@1uokun 1uokun merged commit 08d3ce9 into ant-design:master Oct 8, 2022
1uokun added a commit that referenced this pull request Oct 13, 2022
@1uokun 1uokun mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants