-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All links to demo source code in documentation are broken #134
Comments
Here is the correct link to the demo source code for this example: https://github.com/ant-design/ant-design-mobile-rn/blob/master/components/picker/demo/basic.tsx
So notice that the correct/working link ends in I could help with a PR to fix the docs if you give me a hint how to do that? Would you like me to help? :-) |
@joelgetaction PR are always welcome. The link has broken because I removed the '.native' suffix on master brunch. And the documentation needs update too. for more contexts please move to #119 . |
Thanks for responding @BANG88 ! I would be happy to add a PR but I can't find where the documentation is ... Where would I make changes to the documentation to fix the broken links? I checked out #119 but all the comments are in Chinese and unfortunately I don't speak Chinese ... Is there a way to see the comments in English or would this encourage broader participation - if the comments were in English? Thanks again. |
@joelgetaction sorry about that. The broken link has been fixed on local branch and not published yet. One more thing the issue was I renamed the files under master branch which not synced with the latest documentation. Thanks for you help again. 😄 |
@joelgetaction Please refresh the documentation and you will see the latest version with link fixed. |
It works now! Thanks @BANG88 ! :-) |
Version
undefined
Environment
macOS 10.13.6, react-native 0.57
Reproduction link
https://github.com/ant-design/ant-design-mobile-rn/blob/master/components/picker/demo/basic.native.tsx
Steps to reproduce
What is expected?
Links to demo source code in the documentation should work
What is actually happening?
Links to demo source code in the documentation do NOT work.
This makes it really hard to use Ant react native, because the documenation doesn't show any sample source and the links to demos are all broken ... So how am I supposed to use these components?
The text was updated successfully, but these errors were encountered: