chore: using swc instead of esbuild to fix tree shaking that doesn't work #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadCcc
approved these changes
Aug 1, 2023
afc163
reviewed
Aug 1, 2023
20 tasks
Merged
This was referenced Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原因
由于最终使用
esbuild构建，而esbuild有 top-level-var 的问题，将会把打包的产物中的const和let转为var，因此 tree shaking 发现如果一个变量是以var声明的会认为这个变量包含 side effect，所以将不会对其进行 tree shaking。解决方案
transformer设置为swcvar改写成const