Update docs considering changes on Rocky 24R2 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
igortg
commented
May 24, 2024
igortg
commented
- Explicit list PyRocky differences on GetTimeSet and GetCurves methods
- Use "PrePost Scripting" instead of "PrePost API" to refers to the Rocky scripting feature (changed on 24R2)
- Fix the docstring content of launcher.py
- CONTRIBUTING.md now points to the PyRock Contributing section of PyRocky Developer's Guide
- Adds a small intro to the Developer's guide index page and remove the "How to Contribute" card (not something we want to highlight for the casual user)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 5 5
Lines 157 157
=======================================
Hits 148 148
Misses 9 9 ☔ View full report in Codecov by Sentry. |
igortg
force-pushed
the
fb-docs-24R2
branch
3 times, most recently
from
1e68f4b
to
91d92a2
Compare
- Explicit list PyRocky differences on GetTimeSet and GetCurves methods - Use "PrePost Scripting" instead of "PrePost API" to refers to the Rocky scripting feature (changed on 24R2) - Fix the docstring content of launcher.py - CONTRIBUTING.md now points to the PyRock Contributing section of PyRocky Developer's Guide - Adds a small intro to the Developer's guide index page and remove the "How to Contribute" card (not something we want to highlight for the casual user)
fingeraugusto
approved these changes
May 27, 2024
JanainaO
approved these changes
May 28, 2024
PipKat
reviewed
Jun 4, 2024
PipKat
reviewed
Jun 4, 2024
PipKat
reviewed
Jun 4, 2024
PipKat
reviewed
Jun 4, 2024
PipKat
reviewed
Jun 4, 2024
PipKat
reviewed
Jun 4, 2024
PipKat
reviewed
Jun 4, 2024
PipKat
reviewed
Jun 4, 2024
PipKat
reviewed
Jun 4, 2024
PipKat
reviewed
Jun 4, 2024
PipKat
reviewed
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.