Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make instructions to install "requests" more visible in the docs #136

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

igortg
Copy link
Collaborator

@igortg igortg commented Nov 28, 2024

Instructions explaining that the "requests" library is required and must be installed separately were not noticeable enough. This moves the instruction to a new paragraph to make them more evident.

Fix #119

image

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (d2fd38c) to head (b93df54).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files           7        7           
  Lines         216      216           
=======================================
  Hits          198      198           
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Adrian-B-Moreira Adrian-B-Moreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Instructions explaining that the "requests" library is required and must
be installed separately were not noticeable enough. This moves the
instruction to a new paragraph to make them more evident.

Fix #119
@igortg igortg merged commit 22283a9 into main Nov 28, 2024
23 checks passed
@igortg igortg deleted the docs-example-requests branch November 28, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyRocky: ansys-rocky-core does not find module named 'requests'
2 participants