Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return rocky version through a function #124

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Adrian-B-Moreira
Copy link
Collaborator

The code was trying to update the _ROCKY_VERSION variable before the Rocky's process was raised. The solution was to use a function to return the version in every place that it is required, instead of saving it inside a variable.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (fcbb5c1) to head (4f4a52d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   92.52%   92.48%   -0.04%     
==========================================
  Files           7        7              
  Lines         214      213       -1     
==========================================
- Hits          198      197       -1     
  Misses         16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Adrian-B-Moreira Adrian-B-Moreira merged commit 0e22fa1 into main Nov 13, 2024
23 checks passed
@Adrian-B-Moreira Adrian-B-Moreira deleted the encapsulate-rocky-version branch November 13, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants