Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make jupyter.py compatible for upstream ansys-jupyterhub-manager #842

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

akaszynski
Copy link
Collaborator

Modify jupyter.py to work with changes from ansys-jupyterhub-manager. Specifically, assembly and execution of the spawning of MAPDL is offloaded and resonsibility is limited to instantiating MAPDL.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this is my expertise, but I thought it could be interesting to have a look at this PR.

I do have just one suggestion regarding argument passing.
Other than that, for what is worth I approve the changes.

ansys/mapdl/core/jupyter.py Outdated Show resolved Hide resolved
ansys/mapdl/core/jupyter.py Show resolved Hide resolved
@akaszynski akaszynski merged commit a09e2e1 into main Jan 19, 2022
@akaszynski akaszynski deleted the fix/jupyter_refactor branch January 19, 2022 14:57
akaszynski added a commit that referenced this pull request Jan 21, 2022
* make jupyter.py compatible for upstream ansys-jupyterhub-manager

* Update ansys/mapdl/core/jupyter.py

Co-authored-by: German <[email protected]>

Co-authored-by: German <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants