Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Verification Manual VM7 #785

Merged
merged 30 commits into from
Jan 13, 2022
Merged

Add Verification Manual VM7 #785

merged 30 commits into from
Jan 13, 2022

Conversation

RomanIlchenko1308
Copy link
Contributor

This PR adds VM7, with good step by step explanations, how to provide full simulation of the Plastic Compression of a Pipe Assembly using PyMapdl.

The first commit has got the VM7 with converted code from MAPDL into PyMAPDL.

@RomanIlchenko1308 RomanIlchenko1308 mentioned this pull request Dec 17, 2021
Closed
10 tasks
@RomanIlchenko1308
Copy link
Contributor Author

Hi @akaszynski ,
after your advice "add into req doc and req text pyvista==0.32.1"
everything is working and everything is green.
Thank you for your advice!

akaszynski
akaszynski reviewed Jan 6, 2022
View reviewed changes
requirements_docs.txt Outdated Show resolved Hide resolved
@akaszynski akaszynski requested a review from germa89 January 7, 2022 18:06
germa89
germa89 requested changes Jan 7, 2022
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice piece of work. I like the dataframe output quite a lot.

I have made some comments for you to consider. In addition, I'm not convinced this should be a dynamic example. A static example could have do the job without overloading more the building process.

If made static, the eplot could be "interactive" as Tech Demo 1.

examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Show resolved Hide resolved
@akaszynski
Copy link
Collaborator

Ping @germa89 when ready for a final review. I'm fine with this as-is.

@RomanIlchenko1308
Copy link
Contributor Author

Hi German (@germa89),
if it is possible, can you check please all modifications of the VM7?
Thank you in advance!

germa89
germa89 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job.

Do NOT let the amount of comments I did diminishes your work. Most of my comments are suggestions, feel free to include them or not. However three important remarks:

  • Capitalization. You seems to mix uppercase and lower case too frequently.
  • Check the eplot generated figure. I'm not sure we want that there.
  • Also, are we keeping the pandas thing?

After these three things have been addressed, in my opinion, you can merge.

examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Outdated Show resolved Hide resolved
examples/06-verif-manual/vm-007-plastic_compression_of_a_pipe_assembly.py Show resolved Hide resolved
@RomanIlchenko1308
Copy link
Contributor Author

Thank you, German(@germa89), for your suggestions.
I really appreciate your help!

@RomanIlchenko1308 RomanIlchenko1308 merged commit c9ad2b9 into main Jan 13, 2022
@RomanIlchenko1308 RomanIlchenko1308 deleted the doc/vm7 branch January 13, 2022 16:41
@germa89
Copy link
Collaborator

germa89 commented Jan 13, 2022

Perfect! Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germa89 germa89 germa89 approved these changes

@akaszynski akaszynski akaszynski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomanIlchenko1308 @akaszynski @germa89