Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing arguments on OCDATA command #3226

Merged
merged 7 commits into from
Jul 11, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 27, 2024

Description

Adding missing arguments in OCDATA command.

Issue linked

Close #3199

Checklist

@germa89 germa89 requested a review from a team as a code owner June 27, 2024 14:03
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jun 27, 2024
@germa89 germa89 self-assigned this Jun 27, 2024
@germa89 germa89 added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Jun 27, 2024
@germa89 germa89 enabled auto-merge (squash) June 27, 2024 14:04
@github-actions github-actions bot removed the CI/CD Related with CICD, Github Actions, etc label Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.25%. Comparing base (6090584) to head (93811d2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3226      +/-   ##
==========================================
- Coverage   86.69%   84.25%   -2.45%     
==========================================
  Files          53       53              
  Lines        9629     9629              
==========================================
- Hits         8348     8113     -235     
- Misses       1281     1516     +235     

@germa89
Copy link
Collaborator Author

germa89 commented Jun 27, 2024

@klmcadams can we have pyansys bot commit message compliant with the commit message requirements? 🥲

@klmcadams
Copy link

@germa89 I just made a PR for the commit message here if you want to check it out: ansys/actions#513

@germa89
Copy link
Collaborator Author

germa89 commented Jun 28, 2024

@germa89 I just made a PR for the commit message here if you want to check it out: ansys/actions#513

As always I'm late to the review party. But thank you a lot @klmcadams !!

auto-merge was automatically disabled June 28, 2024 16:58

Pull Request is not mergeable

@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) and removed maintenance General maintenance of the repo (libraries, cicd, etc) labels Jul 8, 2024
@germa89 germa89 enabled auto-merge (squash) July 8, 2024 14:46
@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) and removed documentation Documentation related (improving, adding, etc) labels Jul 8, 2024
@germa89 germa89 changed the title doc: fix the missing arguments on OCDATA command fix: missing arguments on OCDATA command Jul 8, 2024
@germa89 germa89 changed the title fix: missing arguments on OCDATA command fix: missing arguments on OCDATA command Jul 8, 2024
@github-actions github-actions bot removed the documentation Documentation related (improving, adding, etc) label Jul 8, 2024
@germa89 germa89 merged commit 5dd69fe into main Jul 11, 2024
45 checks passed
@germa89 germa89 deleted the fix/ocdata-command-missing-arguments branch July 11, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCDATA can define up to 14 values. PyMAPDL OCDATA limits to 4.
5 participants