Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Vale>=3 #652

Merged
merged 2 commits into from
May 27, 2024
Merged

Migrate to Vale>=3 #652

merged 2 commits into from
May 27, 2024

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented May 27, 2024

@PProfizi PProfizi added the maintenance Repository structure maintenance label May 27, 2024
@PProfizi PProfizi self-assigned this May 27, 2024
@PProfizi PProfizi requested a review from BClappe May 27, 2024 09:05
@@ -4,6 +4,7 @@
ANSYS
API
HDF5
mecanic
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to fix this misspell because of potential breaking changes? @PProfizi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @BClappe, sadly this is everywhere in the old Solution API.
Once the Solution object is deprecated and removed, we can remove this exception.

@PProfizi PProfizi merged commit e47a80a into master May 27, 2024
30 checks passed
@PProfizi PProfizi deleted the maint/migrate_to_vale_3 branch May 27, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Repository structure maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants