Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept rank-1 NumPy arrays for workflow and operator inputs which accept lists #2025

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Accept rank-1 NumPy arrays for workflow and operator inputs which accept lists #2025

merged 8 commits into from
Jan 21, 2025

Conversation

cbellot000
Copy link
Contributor

@cbellot000 cbellot000 commented Jan 20, 2025 •
edited by PProfizi
Loading

This adds support for giving lists to operator or workflow inputs in the format of a rank 1 NumPy array.

@cbellot000 cbellot000 requested a review from PProfizi January 20, 2025 17:22
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (150a2a0) to head (a68c7c7).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2025      +/-   ##
==========================================
- Coverage   88.51%   88.48%   -0.04%     
==========================================
  Files          90       90              
  Lines       10269    10263       -6     
==========================================
- Hits         9090     9081       -9     
- Misses       1179     1182       +3

@PProfizi PProfizi added the enhancement New feature or request label Jan 21, 2025
@PProfizi PProfizi changed the title Workflow and Operator connect numpy array Accept NumPy 1D arrays for workflow and operator inputs accepting lists Jan 21, 2025
@PProfizi PProfizi changed the title Accept NumPy 1D arrays for workflow and operator inputs accepting lists Accept NumPy rank-1 arrays for workflow and operator inputs accepting lists Jan 21, 2025
@PProfizi PProfizi changed the title Accept NumPy rank-1 arrays for workflow and operator inputs accepting lists Accept rank-1 NumPy arrays for workflow and operator inputs which accept lists Jan 21, 2025
@PProfizi PProfizi added this to the 0.13.5 milestone Jan 21, 2025
PProfizi
PProfizi requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@PProfizi PProfizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required anymore, and raises Code Quality errors

src/ansys/dpf/core/misc.py Outdated Show resolved Hide resolved
src/ansys/dpf/core/misc.py Outdated Show resolved Hide resolved
src/ansys/dpf/core/dpf_operator.py Outdated Show resolved Hide resolved
src/ansys/dpf/core/workflow.py Outdated Show resolved Hide resolved
@PProfizi PProfizi self-requested a review January 21, 2025 16:26
@PProfizi PProfizi merged commit 633ad27 into master Jan 21, 2025
46 checks passed
@PProfizi PProfizi deleted the feat/connect_array branch January 21, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PProfizi PProfizi PProfizi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.13.5
Development

Successfully merging this pull request may close these issues.
2 participants
@cbellot000 @PProfizi