Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: driving dimensions #1340

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
6ea7e85
get and set for driving dimensions
umutsoysalansys Jul 31, 2024
cf40188
Merge branch 'main' into feat/driving-dimensions
umutsoysalansys Aug 2, 2024
a1ae758
chore: adding changelog file 1340.added.md
pyansys-ci-bot Aug 2, 2024
f7b7408
chore: adding changelog file 1340.added.md
pyansys-ci-bot Aug 2, 2024
43446c9
Merge branch 'main' into feat/driving-dimensions
umutsoysalansys Aug 13, 2024
f0445bd
chore: adding changelog file 1340.added.md
pyansys-ci-bot Aug 13, 2024
2d092ff
contn
umutsoysalansys Aug 14, 2024
61bc06f
renaming
umutsoysalansys Sep 23, 2024
cf07838
merge commit
umutsoysalansys Sep 23, 2024
f98afd4
change file names
umutsoysalansys Sep 23, 2024
bbe941e
chore: adding changelog file 1340.added.md
pyansys-ci-bot Sep 23, 2024
3f91e63
Merge branch 'main' into feat/driving-dimensions
umutsoysalansys Oct 9, 2024
9b71ccb
Merge branch 'main' into feat/driving-dimensions
umutsoysalansys Oct 14, 2024
0fae95a
parameter updated
umutsoysalansys Oct 14, 2024
7fad5ca
unit test for parameters
umutsoysalansys Oct 15, 2024
a9ae7ae
refactor
umutsoysalansys Oct 16, 2024
d59a102
Merge branch 'main' into feat/driving-dimensions
umutsoysalansys Oct 16, 2024
d0a75c0
review refactor
umutsoysalansys Oct 16, 2024
f07ee2f
Merge branch 'feat/driving-dimensions' of https://github.com/ansys/py…
umutsoysalansys Oct 16, 2024
e4c3ea0
review refactor2
umutsoysalansys Oct 16, 2024
1040750
remove failing test
umutsoysalansys Oct 16, 2024
b9bc8bf
example for parameters is added.
umutsoysalansys Oct 21, 2024
19eed42
Update doc/source/examples/03_modeling/design_parameters.mystnb
umutsoysalansys Oct 22, 2024
b1de850
Update doc/source/examples/03_modeling/design_parameters.mystnb
umutsoysalansys Oct 22, 2024
c541f27
Update doc/source/examples/03_modeling/design_parameters.mystnb
umutsoysalansys Oct 22, 2024
13ae769
doc updates
umutsoysalansys Oct 22, 2024
f80327e
Merge branch 'feat/driving-dimensions' of https://github.com/ansys/py…
umutsoysalansys Oct 22, 2024
091deaf
merge commit
umutsoysalansys Oct 22, 2024
a864754
Merge branch 'main' into feat/driving-dimensions
umutsoysalansys Oct 22, 2024
d9d9ed4
doc updates
umutsoysalansys Oct 22, 2024
5619073
revert deleted test
umutsoysalansys Oct 22, 2024
ded6cf2
merge with main
umutsoysalansys Oct 29, 2024
bbfa8b7
Merge branch 'main' into feat/driving-dimensions
umutsoysalansys Nov 13, 2024
24deb62
Update doc/source/examples/03_modeling/design_parameters.mystnb
umutsoysalansys Nov 13, 2024
777533b
Update doc/source/examples/03_modeling/design_parameters.mystnb
umutsoysalansys Nov 13, 2024
ce643b7
Update doc/source/examples/03_modeling/design_parameters.mystnb
umutsoysalansys Nov 13, 2024
8c4bbb1
Update doc/source/examples/03_modeling/design_parameters.mystnb
umutsoysalansys Nov 13, 2024
b2ce393
Update src/ansys/geometry/core/parameters/parameter.py
umutsoysalansys Nov 13, 2024
59416c8
Update src/ansys/geometry/core/parameters/parameter.py
umutsoysalansys Nov 13, 2024
1f7edbb
Update tests/integration/test_design.py
umutsoysalansys Nov 13, 2024
86e28ca
Update src/ansys/geometry/core/parameters/parameter.py
umutsoysalansys Nov 13, 2024
3b46ae3
Update src/ansys/geometry/core/parameters/parameter.py
umutsoysalansys Nov 13, 2024
9c427e1
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] Nov 13, 2024
bb2b7b1
Update src/ansys/geometry/core/parameters/parameter.py
umutsoysalansys Nov 13, 2024
ba914b2
Update src/ansys/geometry/core/parameters/parameter.py
umutsoysalansys Nov 13, 2024
2dd5169
Update src/ansys/geometry/core/parameters/parameter.py
umutsoysalansys Nov 13, 2024
9d575bf
Update src/ansys/geometry/core/parameters/parameter.py
umutsoysalansys Nov 13, 2024
4f8ea14
Merge branch 'main' into feat/driving-dimensions
umutsoysalansys Nov 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/1340.added.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
driving dimensions
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions doc/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ def intersphinx_pyansys_geometry(switcher_version: str):
"examples/03_modeling/design_tree": "_static/thumbnails/design_tree.png",
"examples/03_modeling/service_colors": "_static/thumbnails/service_colors.png",
"examples/03_modeling/surface_bodies": "_static/thumbnails/quarter_sphere.png",
"examples/03_modeling/design_parameters": "_static/thumbnails/block_with_parameters.png",
"examples/04_applied/01_naca_airfoils": "_static/thumbnails/naca_airfoils.png",
"examples/04_applied/02_naca_fluent": "_static/thumbnails/naca_fluent.png",
}
Expand Down
2 changes: 2 additions & 0 deletions doc/source/examples.rst
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ These examples demonstrate service-based modeling operations.
examples/03_modeling/design_tree.mystnb
examples/03_modeling/service_colors.mystnb
examples/03_modeling/surface_bodies.mystnb
examples/03_modeling/design_parameters.mystnb


Applied examples
----------------
Expand Down
145 changes: 145 additions & 0 deletions doc/source/examples/03_modeling/design_parameters.mystnb
Original file line number Diff line number Diff line change
@@ -0,0 +1,145 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be interesting to add an extra body with a fixed size so that after modifying the parameters, when you request plotting, you can visually see the difference with respect to the first plot. This is just a suggestion though - feel free to disregard =)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I replaced the file with another object on the side as a scale

jupytext:
text_representation:
extension: .mystnb
format_name: myst
format_version: 0.13
jupytext_version: 1.16.4
kernelspec:
display_name: Python 3 (ipykernel)
language: python
name: python3
---

# Modeling: Using design parameters

You can read and update parameters that are part of the design.
In this example, we have a simple design with two associated parameters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this example, we have a simple design with two associated parameters.
In this example, the simple design has two associated parameters.

Avoid "we" and use active voice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reviews @PipKat, I used "we" based on the previous examples on this examples section, so maybe they need to be corrected as well? thanks
https://github.com/ansys/pyansys-geometry/blob/150c19b9dabe92e999262f89233970efc5c6c96a/doc/source/examples/01_getting_started/05_plotter_picker.mystnb#L177C23-L177C30

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the guideline: Avoid first-person pronouns (I, we, us, our, and ours), For more information, see https://developers.google.com/style/pronouns#personal-pronouns.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @umutsoysalansys - correct, @PipKat tries to review our examples on a best effort basis, but she might have missed the one you linked. I will review that one myself so that it is in-line with the style guidelines. Thank you as always @PipKat!


+++

## Perform required imports

```{code-cell} ipython3
import os
import requests
from ansys.geometry.core import launch_modeler
from ansys.geometry.core.modeler import *
from ansys.geometry.core.parameters import *
```

The file for this example is in the integration tests folder, so let's download it.

Comment on lines +31 to +32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The file for this example is in the integration tests folder, so let's download it.

Move this info to the download section.

+++

## Download the example file

+++

Download the file for this example from the integration tests folder in the PyAnsys Geometry repository.

```{code-cell} ipython3
import requests

def download_file(url, filename):
"""Download a file from a URL and save it to a local file."""
response = requests.get(url)
response.raise_for_status() # Check if the request was successful
with open(filename, 'wb') as file:
file.write(response.content)

# URL of the file to download
url = "https://github.com/ansys/pyansys-geometry/blob/main/tests/integration/files/blockswithparameters.dsco"

# Local path where the file will be saved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Local path where the file will be saved
# Local path to save the file to

file_name = "blockswithparameters.dsco"
current_path = os.getcwd()
file_path = os.path.join(current_path, file_name)
# Download the file
download_file(url, file_path)
print("File is downloaded to " + file_path)
```

## Import a design with parameters

+++

Importing the model using ``open_file`` method of the modeler.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Importing the model using ``open_file`` method of the modeler.
Import the model using the ``open_file()`` method of the modeler.


```{code-cell} ipython3
# Create a modeler object
modeler = launch_modeler()
design = modeler.open_file(file_path)
design.plot()
```

## Read existing parameters of the design

You can get all the parameters of the design as a list of parameters. Because this example has two parameters, you see the two items in the list.

```{code-cell} ipython3
my_parameters = design.get_all_parameters()
print(len(my_parameters))
```

A parameter object has a name, value, and unit.

```{code-cell} ipython3
print(my_parameters[0].name)
print(my_parameters[0].dimension_value)
print(my_parameters[0].dimension_type)

print(my_parameters[1].name)
print(my_parameters[1].dimension_value)
print(my_parameters[1].dimension_type)
```

Parameter values are returned in the default unit for each dimension type. Since default length unit is meter and default area unit is meter square, the value is returned in metersquare.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Parameter values are returned in the default unit for each dimension type. Since default length unit is meter and default area unit is meter square, the value is returned in metersquare.
Parameter values are returned in the default unit for each dimension type. Because the default length unit is meter and the default area unit is meter square, the value is returned in metersquare.


+++

## Edit a parameter value

You can edit the parameters name or value by simply setting these fields. Let's
set the second parameter (p2 value to 350 mm. )
Comment on lines +103 to +104
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can edit the parameters name or value by simply setting these fields. Let's
set the second parameter (p2 value to 350 mm. )
You can edit a parameter's name or value by simply setting these fields. This code
sets the second parameter (p2 value) to 350 mm.

I see parameter1 being set to 0.000440, but that's not what the text says. Is an update to the next needed?


```{code-cell} ipython3
parameter1 = my_parameters[1]
parameter1.dimension_value = 0.000440
response = design.set_parameter(parameter1)
print(response)
print(my_parameters[0].dimension_value)
print(my_parameters[1].dimension_value)
```

After a successful parameter update the design in the backend might have been updated. Therefore you need to refresh the design on the client.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After a successful parameter update the design in the backend might have been updated. Therefore you need to refresh the design on the client.
After a successful parameter update, the design in the backend might have been updated. Therefore, you must refresh the design on the client.


```{code-cell} ipython3
design = modeler.read_existing_design()
design.plot()
```

The ``set_parameter()`` method returns a ``Success`` status message if the parameter is updated or a "FAILURE" status message if the update fails. If the ``p2`` parameter depends on the ``p1`` parameter, updating the ``p1`` parameter might also change the ``p2`` parameter. In such cases, the method returns ``CONSTRAINED_PARAMETERS``, which indicates other parameters were also updated.

```{code-cell} ipython3
parameter1 = my_parameters[0]
parameter1.dimension_value = 0.000250
response = design.set_parameter(parameter1)
print(response)
```

Therefore user can query the parameters once again to get updated list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Therefore user can query the parameters once again to get updated list.
You can query the parameters once again to get the updated list.


```{code-cell} ipython3
my_parameters = design.get_all_parameters()
print(my_parameters[0].dimension_value)
print(my_parameters[1].dimension_value)
```

## Close the modeler

Close the modeler to free up resources and release the connection.

```{code-cell} ipython3
modeler.close()
```
48 changes: 48 additions & 0 deletions src/ansys/geometry/core/designer/design.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
from ansys.api.dbu.v0.dbumodels_pb2 import EntityIdentifier, PartExportFormat
from ansys.api.dbu.v0.designs_pb2 import InsertRequest, NewRequest, SaveAsRequest
from ansys.api.dbu.v0.designs_pb2_grpc import DesignsStub
from ansys.api.dbu.v0.drivingdimensions_pb2 import GetAllRequest, UpdateRequest
from ansys.api.dbu.v0.drivingdimensions_pb2_grpc import DrivingDimensionsStub
from ansys.api.geometry.v0.commands_pb2 import (
AssignMidSurfaceOffsetTypeRequest,
AssignMidSurfaceThicknessRequest,
Expand Down Expand Up @@ -74,6 +76,7 @@
from ansys.geometry.core.misc.checks import ensure_design_is_active, min_backend_version
from ansys.geometry.core.misc.measurements import DEFAULT_UNITS, Distance
from ansys.geometry.core.modeler import Modeler
from ansys.geometry.core.parameters.parameter import Parameter, ParameterUpdateStatus
from ansys.geometry.core.typing import RealSequence


Expand Down Expand Up @@ -125,6 +128,7 @@ def __init__(self, name: str, modeler: Modeler, read_existing_design: bool = Fal
self._materials_stub = MaterialsStub(self._grpc_client.channel)
self._named_selections_stub = NamedSelectionsStub(self._grpc_client.channel)
self._parts_stub = PartsStub(self._grpc_client.channel)
self._parameters_stub = DrivingDimensionsStub(self._grpc_client.channel)

# Initialize needed instance variables
self._materials = []
Expand Down Expand Up @@ -166,6 +170,11 @@ def beam_profiles(self) -> list[BeamProfile]:
"""List of beam profile available for the design."""
return list(self._beam_profiles.values())

@property
def parameters(self) -> list[Parameter]:
"""List of parameters available for the design."""
return self.get_all_parameters()

umutsoysalansys marked this conversation as resolved.
Show resolved Hide resolved
@property
def is_active(self) -> bool:
"""Whether the design is currently active."""
Expand Down Expand Up @@ -679,6 +688,45 @@ def add_beam_circular_profile(

return self._beam_profiles[profile.name]

@protect_grpc
@min_backend_version(25, 1, 0)
def get_all_parameters(self) -> list[Parameter]:
"""Get parameters for the design.

Returns
-------
list[Parameter]
List of parameters for the design.
"""
response = self._parameters_stub.GetAll(GetAllRequest())
return [Parameter._from_proto(dimension) for dimension in response.driving_dimensions]

@protect_grpc
@check_input_types
@min_backend_version(25, 1, 0)
def set_parameter(self, dimension: Parameter) -> ParameterUpdateStatus:
"""Update a parameter of the design.

Parameters
----------
dimension : Parameter
Parameter to set.

Returns
-------
ParameterUpdateStatus
Status of the update operation.
"""
request = UpdateRequest(driving_dimension=Parameter._to_proto(dimension))
response = self._parameters_stub.UpdateParameter(request)
status = response.status

# Update the design in place. This method is expensive,
# consider finding a more efficient approach.
self._update_design_inplace()

return ParameterUpdateStatus._from_update_status(status)

@protect_grpc
@check_input_types
@ensure_design_is_active
Expand Down
24 changes: 24 additions & 0 deletions src/ansys/geometry/core/parameters/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Copyright (C) 2023 - 2024 ANSYS, Inc. and/or its affiliates.
# SPDX-License-Identifier: MIT
#
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in all
# copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
"""PyAnsys Geometry parameters subpackage."""

from ansys.geometry.core.parameters.parameter import Parameter, ParameterType
Loading
Loading