Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set component type #977

Merged
merged 6 commits into from
Mar 23, 2022
Merged

Set component type #977

merged 6 commits into from
Mar 23, 2022

Conversation

hui-zhou-a
Copy link
Contributor

@codecov
Copy link

codecov bot commented Mar 22, 2022 •
edited
Loading

Codecov Report

Merging #977 (eb6b5d6) into main (fa4d455) will increase coverage by 0.02%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
+ Coverage   80.75%   80.78%   +0.02%     
==========================================
  Files         128      129       +1     
  Lines       38170    38304     +134     
==========================================
+ Hits        30825    30942     +117     
- Misses       7345     7362      +17

maxcapodi78
maxcapodi78 approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-zhou-a
Copy link
Contributor Author

@maxcapodi78 it is failing ironpython. I should I skip ironpython for the test?

@maxcapodi78 maxcapodi78 merged commit b8e5fc2 into main Mar 23, 2022
@maxcapodi78 maxcapodi78 deleted the Set_component_type branch March 23, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@maxcapodi78 maxcapodi78 maxcapodi78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hui-zhou-a @maxcapodi78 @MaxJPRey