-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to component creation #944
Conversation
Also refactor create_new_component_from_symbol to add additional capability and correct
Codecov Report
@@ Coverage Diff @@
## main #944 +/- ##
==========================================
+ Coverage 80.31% 80.46% +0.14%
==========================================
Files 128 128
Lines 37696 37679 -17
==========================================
+ Hits 30276 30318 +42
+ Misses 7420 7361 -59 |
Hi @MaxJPRey , please could you check why is failing the Style Check? Thanks! |
Increase unittest coverage
Hi @maxcapodi78 , Dave implemented 2 new methods, and we realized 'create_new_component_from_symbol' was duplicated in 2 different classes 'PrimitivesNexxim' and 'PrimitivesCircuit'. After a check, I removed it from Primitives Circuit. In addition, this method was not cover by the unittest, and @seeyouatcloudbase add a new unittest. Could you verify the duplicate method was a error? Thanks |
@Samuelopez-ansys I am looking at the style check issue. |
Thanks @MaxJPRey , for next PR, how could we know where the style check is failing? I didn't find where was the issue... thanks |
No description provided.