Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to component creation #944

Merged
merged 5 commits into from
Mar 11, 2022
Merged

Conversation

seeyouatcloudbase
Copy link
Contributor

No description provided.

Also refactor create_new_component_from_symbol to add additional capability and correct
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #944 (9f0715e) into main (9c1b223) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
+ Coverage   80.31%   80.46%   +0.14%     
==========================================
  Files         128      128              
  Lines       37696    37679      -17     
==========================================
+ Hits        30276    30318      +42     
+ Misses       7420     7361      -59     

@Samuelopez-ansys
Copy link
Member

Hi @MaxJPRey , please could you check why is failing the Style Check?

Thanks!

Increase unittest coverage
@Samuelopez-ansys
Copy link
Member

Hi @maxcapodi78 ,

Dave implemented 2 new methods, and we realized 'create_new_component_from_symbol' was duplicated in 2 different classes 'PrimitivesNexxim' and 'PrimitivesCircuit'. After a check, I removed it from Primitives Circuit.

In addition, this method was not cover by the unittest, and @seeyouatcloudbase add a new unittest. Could you verify the duplicate method was a error?

Thanks

@MaxJPRey
Copy link
Collaborator

@Samuelopez-ansys I am looking at the style check issue.

@Samuelopez-ansys
Copy link
Member

Thanks @MaxJPRey , for next PR, how could we know where the style check is failing? I didn't find where was the issue... thanks

@Samuelopez-ansys Samuelopez-ansys merged commit 24e022e into main Mar 11, 2022
@Samuelopez-ansys Samuelopez-ansys deleted the fixes_to_component_creation branch March 11, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

added a function addpiniports to add ports on all pins
3 participants