Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support touchstone file with more than 9 ports. #935

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Conversation

MaxJPRey
Copy link
Collaborator

@MaxJPRey MaxJPRey commented Mar 9, 2022

Support touchstone file with more than 9 ports.
Previously we were only selecting the last digit to get the number of ports contained in the touchstone file.

Fix #928

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #935 (d093ec1) into main (5389252) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
- Coverage   80.21%   80.21%   -0.01%     
==========================================
  Files         128      128              
  Lines       37419    37419              
==========================================
- Hits        30015    30014       -1     
- Misses       7404     7405       +1     

@jhillairet
Copy link

If not done before in the code, I would suggest to lower() the touchstone_full_path somewhere, as one can often sees Touchstone files with using upper cases extentions such as : '.S2P'

@MaxJPRey
Copy link
Collaborator Author

If not done before in the code, I would suggest to lower() the touchstone_full_path somewhere, as one can often sees Touchstone files with using upper cases extentions such as : '.S2P'

Great suggestion @jhillairet . It is done. Thanks.

Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 merged commit 9c1b223 into main Mar 11, 2022
@maxcapodi78 maxcapodi78 deleted the fix/issue_928 branch March 11, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_touchsthone_component() is not working properly
3 participants