Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameter name from 'udptye' to 'udp_type' in create_udp() method. #884

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

MaxJPRey
Copy link
Collaborator

Change parameter name from 'udptye' to 'udp_type' in create_udp() method.

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #884 (2ab8abf) into main (be37385) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #884   +/-   ##
=======================================
  Coverage   78.97%   78.97%           
=======================================
  Files         128      128           
  Lines       35642    35642           
=======================================
  Hits        28147    28147           
  Misses       7495     7495           

@MaxJPRey MaxJPRey linked an issue Feb 21, 2022 that may be closed by this pull request
Copy link
Contributor

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxJPRey MaxJPRey merged commit 75c6236 into main Feb 21, 2022
@MaxJPRey MaxJPRey deleted the fix/issue_847 branch February 21, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of UDPs
2 participants