Model depth for Maxwell 2D transient analysis is now a property with getter/setter. #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erties. Those properties are not updated when the project has been saved.
akaszynski
reviewed
Jan 24, 2022
pyaedt/maxwell.py
Outdated
|
|
||
| >>> from pyaedt import Maxwell2d | ||
| >>> maxwell_2d = Maxwell2d() | ||
| >>> maxwell_2d.model_depth="90 mm" |
There was a problem hiding this comment.
Suggested change
| >>> maxwell_2d.model_depth="90 mm" | |
| >>> maxwell_2d.model_depth = "90 mm" |
maxcapodi78
reviewed
Jan 24, 2022
_unittest/test_27_Maxwell2D.py
Outdated
Comment on lines
111
to
120
|
|
||
| # @pyaedt_unittest_check_desktop_error | ||
| # def test_17_enable_inductance_computation(self): | ||
| # # Set a new value for model depth | ||
| # self.aedtapp.model_depth = "90 mm" | ||
| # assert self.aedtapp.model_depth == 0.09 | ||
| # self.aedtapp.model_depth = "1.3" | ||
| # assert self.aedtapp.model_depth == 1.3 | ||
| # # Generate design data | ||
| # assert self.aedtapp.generate_design_data() |
There was a problem hiding this comment.
If not needed we can remove this comment
There was a problem hiding this comment.
Done. I will reinstate the test when the project properties issue is fixed.
akaszynski
reviewed
Jan 24, 2022
Comment on lines
1174
to
1175
| else: | ||
| return None |
There was a problem hiding this comment.
This seems redundant here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model depth for Maxwell 2D transient analysis is now a property with getter/setter.
Fix #753 .