Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Prepare for EMIT Python 3.12 support. #5248

Merged
merged 7 commits into from
Oct 10, 2024
Merged

FEAT: Prepare for EMIT Python 3.12 support. #5248

merged 7 commits into from
Oct 10, 2024

Conversation

myoung301
Copy link
Contributor

@myoung301 myoung301 commented Oct 4, 2024

Preparing EMIT to provide Python 3.12 starting with AEDT 2025.1.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (08db6d0) to head (a0f2677).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5248      +/-   ##
==========================================
- Coverage   83.26%   83.25%   -0.01%     
==========================================
  Files         142      143       +1     
  Lines       58328    58464     +136     
==========================================
+ Hits        48566    48676     +110     
- Misses       9762     9788      +26     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I left some minor comments.

_unittest_solvers/test_26_emit.py Outdated Show resolved Hide resolved
_unittest_solvers/test_26_emit.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modeler/schematic.py Show resolved Hide resolved
@myoung301
Copy link
Contributor Author

@SMoraisAnsys Thank you for the review. I think I've addressed each of the comments. Please review the updates when you have a chance.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking into account my previous comments and helping us with the changes available with 25.1.
Here are some extra requests as I noticed that there was a typo in our current code base. As far as I know, we still have to handle AEDT versions where EMIT was available with Python 3.8. Therefore, as long as pyaedt is compatible with it (support dropping planned in v1.0.0) we need to keep it.

_unittest_solvers/test_26_emit.py Outdated Show resolved Hide resolved
_unittest_solvers/test_26_emit.py Outdated Show resolved Hide resolved
_unittest_solvers/test_26_emit.py Outdated Show resolved Hide resolved
_unittest_solvers/test_26_emit.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modeler/schematic.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modeler/schematic.py Outdated Show resolved Hide resolved
@myoung301
Copy link
Contributor Author

Thanks again. I think I've addressed each of the comments, but let me know your thoughts.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the changes and the contribution

@myoung301 myoung301 merged commit 4e783b5 into main Oct 10, 2024
42 checks passed
@myoung301 myoung301 deleted the B1057573 branch October 10, 2024 13:22
@myoung301 myoung301 restored the B1057573 branch October 10, 2024 13:22
@myoung301 myoung301 deleted the B1057573 branch October 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants