-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Prepare for EMIT Python 3.12 support. #5248
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5248 +/- ##
==========================================
- Coverage 83.26% 83.25% -0.01%
==========================================
Files 142 143 +1
Lines 58328 58464 +136
==========================================
+ Hits 48566 48676 +110
- Misses 9762 9788 +26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I left some minor comments.
for more information, see https://pre-commit.ci
@SMoraisAnsys Thank you for the review. I think I've addressed each of the comments. Please review the updates when you have a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking into account my previous comments and helping us with the changes available with 25.1.
Here are some extra requests as I noticed that there was a typo in our current code base. As far as I know, we still have to handle AEDT versions where EMIT was available with Python 3.8. Therefore, as long as pyaedt
is compatible with it (support dropping planned in v1.0.0
) we need to keep it.
Thanks again. I think I've addressed each of the comments, but let me know your thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all the changes and the contribution
Preparing EMIT to provide Python 3.12 starting with AEDT 2025.1.