FIX: Issue error and skip material on parse error #5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5217 +/- ##
=======================================
Coverage 83.35% 83.36%
=======================================
Files 142 142
Lines 58189 58193 +4
=======================================
+ Hits 48506 48511 +5
+ Misses 9683 9682 -1 |
2 tasks
isaacwaldron
force-pushed
the
issue-5215
branch
from
93208c4
to
72aa5f9
Compare
maxcapodi78
previously requested changes
Sep 27, 2024
|
Converted to draft to accommodate feedback on test mocking. |
Issue an error message when parsing a material fails in import_materials_from_file.
Co-authored-by: Sébastien Morais <[email protected]>
In tests the error handler is disabled so we need to expect the exception rather than checking for a False return value.
isaacwaldron
force-pushed
the
issue-5215
branch
from
f387c3d
to
b32f7b9
Compare
|
@SMoraisAnsys @maxcapodi78 ready for review once again. |
SMoraisAnsys
approved these changes
Sep 30, 2024
|
@isaacwaldron There seem to be a problem with the changes introduced in #5203 making some of the CICD not running in this PR. I'll try to fix that asap. |
Samuelopez-ansys
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue a specific error message when parsing a material fails in import_materials_from_file. Also directly return False instead of relying on the catch-all exception handler.
Closes #5215