Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Wrong call to logging atexit #5214

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Sep 26, 2024

Removing the call to the debug log because it always end up failing if the desktop is already closed. Indeed, by triggering that log call at exit, we end up trying to write something but the log handler is closed/deleted.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (8161171) to head (686cff1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5214      +/-   ##
==========================================
- Coverage   83.51%   83.36%   -0.16%     
==========================================
  Files         129      142      +13     
  Lines       57728    58182     +454     
==========================================
+ Hits        48212    48501     +289     
- Misses       9516     9681     +165     

@SMoraisAnsys SMoraisAnsys marked this pull request as draft September 26, 2024 13:16
@SMoraisAnsys SMoraisAnsys merged commit 016e679 into main Sep 27, 2024
43 checks passed
@SMoraisAnsys SMoraisAnsys deleted the fix/release-at-exit-logging branch September 27, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants