New Icepak ECAD import example with Ansys board

[ansys-satyajeet]

Pull Request Template

Description

A new example for ECAD import into Icepak with Ansys board. It also covers stackup modification with material property changes.

Checklist

Please complete the following checklist before submitting your pull request:

• [Y] I have followed the example template and guide lines to add/update an example.
• [Y] I have tested the example locally and verified that it is working with the latest version of AEDT.
• [Y] I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

[Samuelopez-ansys]

@ansys-satyajeet @lorenzovecchietti What is the differenc between this example and https://github.com/ansys-internal/pyaedt-examples/blob/main/examples/05-Icepak/icepak_ecad_import.py ?

I think both can be merged.

[Samuelopez-ansys]

@ansys-satyajeet @lorenzovecchietti What is the differenc between this example and https://github.com/ansys-internal/pyaedt-examples/blob/main/examples/05-Icepak/icepak_ecad_import.py ?

I think both can be merged.

[ansys-satyajeet]

@Samuelopez-ansys @lorenzovecchietti This example uses the Ansys board. As I understand correctly, we cannot distribute Galileo board and there are some restrictions on A1 board as well (this board is used in the existing example). Moreover, the old example was too long and combining IDF import with ECAD import. The new example aims to simplify the examples, addressing one specific topic, in this case importing and modify an ECAD in Icepak.

I understand the simplifications and shortening of examples can create more example that may have repeated code, and present testing and maintenance challenges, but for a user it would be very easy to quickly find what they are looking for and thus reduce the questions in Discussions.

[lorenzovecchietti]

Yes, that is perfectly fine. We can just remove the old example and keep just the one you pushed (removing the "v2" from the name)

I wanted also to showcase a bit the features of the pcb object. I couldn't work on this a lot today because the example is failing on my machine (I think the problem is just mine)

[ansys-satyajeet]

Yes, that is perfectly fine. We can just remove the old example and keep just the one you pushed (removing the "v2" from the name)

I wanted also to showcase a bit the features of the pcb object. I couldn't work on this a lot today because the example is failing on my machine (I think the problem is just mine)

Agree, showcasing the pcb component features is a good idea. Is there a way to add more to this existing pull request? Or do I need to create a new pull request for the additional code lines in this example? Not sure about the best practices.

[lorenzovecchietti]

You can just work on your branch and commit to it. Every time you push the changes you'll see the changes also in this PR.

…

________________________________ Da: Satyajeet Padhi ***@***.***> Inviato: giovedì 29 agosto 2024 15:34 A: ansys-internal/pyaedt-examples ***@***.***> Cc: Lorenzo Vecchietti ***@***.***>; Mention ***@***.***> Oggetto: Re: [ansys-internal/pyaedt-examples] New Icepak ECAD import example with Ansys board (PR #221) [External Sender] Yes, that is perfectly fine. We can just remove the old example and keep just the one you pushed (removing the "v2" from the name) I wanted also to showcase a bit the features of the pcb object. I couldn't work on this a lot today because the example is failing on my machine (I think the problem is just mine) Agree, showcasing the pcb component features is a good idea. Is there a way to add more to this existing pull request? Or do I need to create a new pull request for the additional code lines in this example? Not sure about the best practices. — Reply to this email directly, view it on GitHub<#221 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AN5JX4QRKVG34EJI5FO77RDZT4PNHAVCNFSM6AAAAABNJLWVBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJXGY3TKMRRGI>. You are receiving this because you were mentioned.

[ansys-satyajeet]

I have added a few lines to showcase PCB component features. I also modified the file names and tested the code a few times.

[gmalinve]

The example doesn't follow the template.py format. It's not divided into sections and sections don't start with # ## Title followed by a blank line (#) and description (#).
Please look at other examples! :)