Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto-save for parametric study #74

Merged
merged 22 commits into from
Sep 9, 2023
Merged

Add auto-save for parametric study #74

merged 22 commits into from
Sep 9, 2023

Conversation

pkrull-ansys
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Sep 8, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 8, 2023
@pkrull-ansys pkrull-ansys mentioned this pull request Sep 8, 2023
Closed
6 tasks
klmcadams
klmcadams reviewed Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@klmcadams klmcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, your code looks good! I just had a few suggestions for adding more descriptions to the tests, as well as moving the import statements to the top of one of the example files.

examples/04_advanced_parametric_study.py Show resolved Hide resolved
examples/04_advanced_parametric_study.py Outdated Show resolved Hide resolved
examples/04_advanced_parametric_study.py Outdated Show resolved Hide resolved
examples/04_advanced_parametric_study.py Outdated Show resolved Hide resolved
examples/04_advanced_parametric_study.py Outdated Show resolved Hide resolved
tests/parametric_study/test_parametric_study.py Show resolved Hide resolved
tests/parametric_study/test_parametric_study.py Show resolved Hide resolved
tests/parametric_study/test_parametric_study.py Outdated Show resolved Hide resolved
tests/parametric_study/test_parametric_study.py Show resolved Hide resolved
src/ansys/additive/core/parametric_study/display/ave_grain_size_plot.py Show resolved Hide resolved
pkrull-ansys and others added 11 commits September 8, 2023 16:57
@pkrull-ansys @klmcadams
Update examples/04_advanced_parametric_study.py
770df30 
Co-authored-by: Kerry McAdams <[email protected]>
@pkrull-ansys @klmcadams
Update examples/04_advanced_parametric_study.py
dd3ffed 
Co-authored-by: Kerry McAdams <[email protected]>
@pkrull-ansys @klmcadams
Update examples/04_advanced_parametric_study.py
588939c 
Co-authored-by: Kerry McAdams <[email protected]>
@pkrull-ansys @klmcadams
Update examples/04_advanced_parametric_study.py
416992d 
Co-authored-by: Kerry McAdams <[email protected]>
@pkrull-ansys @klmcadams
Update examples/04_advanced_parametric_study.py
bdf410a 
Co-authored-by: Kerry McAdams <[email protected]>
@pkrull-ansys @klmcadams
Update examples/04_advanced_parametric_study.py
687b8dc 
Co-authored-by: Kerry McAdams <[email protected]>
@pkrull-ansys
Sort imports
28a4584
@pkrull-ansys
Use pytest TempPathFactory
d6f67fa
@pkrull-ansys
Reorder doc string
1705487
@pkrull-ansys
Fix pre-commit check
2368acc
@pkrull-ansys
Fix style check
07e6e03
@pkrull-ansys pkrull-ansys enabled auto-merge (squash) September 9, 2023 17:59
@pkrull-ansys pkrull-ansys merged commit 7e87783 into main Sep 9, 2023
24 checks passed
@pkrull-ansys pkrull-ansys deleted the feat/parametric-study-enhancements branch September 9, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klmcadams klmcadams klmcadams left review comments

@deleon117 deleon117 deleon117 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkrull-ansys @deleon117 @klmcadams