Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use weakref.finalize() to shutdown server connection #580

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

pkrull-ansys
Copy link
Collaborator

Closes #508

@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.26%. Comparing base (d953dc1) to head (825f405).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ditive/core/server_connection/server_connection.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          34       34           
  Lines        3395     3401    +6     
=======================================
+ Hits         3302     3308    +6     
  Misses         93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pkrull-ansys pkrull-ansys added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 03984b4 Nov 22, 2024
29 checks passed
@pkrull-ansys pkrull-ansys deleted the feat/508/weakref-finalizer branch November 22, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change __del__ method to weakref.finalizer in Additive
2 participants