Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/163 add separate progress and logger #212

Closed
wants to merge 5 commits into from
Closed

Feat/163 add separate progress and logger #212

wants to merge 5 commits into from

Conversation

safeerehman
Copy link
Collaborator

closes #163

  • Added a Logger class in progress_logger.py
  • Keeping ProgressLogger class as is for now until we use the global logger
  • Added units tests for the Logger class in test_logger.py

@github-actions github-actions bot added the enhancement New features or code improvements label Jan 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (718d2f5) 97.97% compared to head (c6bbb74) 97.61%.

Files Patch % Lines
src/ansys/additive/core/logger.py 85.33% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   97.97%   97.61%   -0.36%     
==========================================
  Files          27       28       +1     
  Lines        2566     2642      +76     
==========================================
+ Hits         2514     2579      +65     
- Misses         52       63      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkrull-ansys
pkrull-ansys requested changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@pkrull-ansys pkrull-ansys left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG.md and bump the version in pyproject.toml

src/ansys/additive/core/progress_logger.py Outdated Show resolved Hide resolved
src/ansys/additive/core/progress_logger.py Outdated Show resolved Hide resolved
src/ansys/additive/core/progress_logger.py Outdated Show resolved Hide resolved
src/ansys/additive/core/progress_logger.py Outdated Show resolved Hide resolved
src/ansys/additive/core/progress_logger.py Outdated Show resolved Hide resolved
tests/test_logger.py Show resolved Hide resolved
tests/test_logger.py Outdated Show resolved Hide resolved
tests/test_logger.py Outdated Show resolved Hide resolved
tests/test_logger.py Outdated Show resolved Hide resolved
tests/test_logger.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 9, 2024
pkrull-ansys
pkrull-ansys approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@pkrull-ansys pkrull-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with suggestions.

CHANGELOG.md Outdated Show resolved Hide resolved
src/ansys/additive/core/logger.py Outdated Show resolved Hide resolved
src/ansys/additive/core/logger.py Show resolved Hide resolved
tests/test_logger.py Show resolved Hide resolved
@safeerehman
Copy link
Collaborator Author

Adding duplicate PR which has all commits signed

@pkrull-ansys pkrull-ansys deleted the feat/163-add-separate-progress-and-logger branch August 14, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkrull-ansys pkrull-ansys pkrull-ansys approved these changes

@julieatansys julieatansys julieatansys approved these changes

Assignees
No one assigned
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace ProgressLogger with separate progress and logger objects
3 participants
@safeerehman @julieatansys @pkrull-ansys