Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ButtJointSequence exposure #606

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Conversation

greschd
Copy link
Member

@greschd greschd commented Oct 3, 2024

Add the ButtJointSequence class, and a PrimaryPly class for the edge properties
of the primary_plies attribute.

Other changes:

  • Add an allowed_types_getter parameter to define_polymorphic_linked_object_list
    with the same purpose as the existing allowed_types, except the types are evaluated
    only inside the getter.
    This was needed to avoid a circular import with the ModelingGroup, since
    define_polymorphic_linked_object_list is called at the module top-level.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.29%. Comparing base (d3986e6) to head (774123c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nsys/acp/core/_tree_objects/butt_joint_sequence.py 91.86% 7 Missing ⚠️
.../_tree_objects/_grpc_helpers/linked_object_list.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   93.33%   93.29%   -0.04%     
==========================================
  Files          86       87       +1     
  Lines        4604     4698      +94     
==========================================
+ Hits         4297     4383      +86     
- Misses        307      315       +8     
Flag Coverage Δ
python-3.10 93.16% <91.66%> (-0.04%) ⬇️
python-3.11 93.08% <91.66%> (-0.04%) ⬇️
python-3.12 93.20% <91.66%> (-0.04%) ⬇️
server-2024R2 92.25% <62.50%> (-0.63%) ⬇️
server-2025R1 93.08% <91.66%> (-0.04%) ⬇️
server-latest 93.16% <91.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greschd greschd force-pushed the feat/582-add-buttjointsequence branch 2 times, most recently from 9853384 to 84cd4de Compare October 3, 2024 16:36
@greschd greschd force-pushed the feat/supported_since_on_class_level branch 2 times, most recently from 9003bd0 to 62d9a6f Compare October 16, 2024 12:56
Base automatically changed from feat/supported_since_on_class_level to main October 16, 2024 13:15
@greschd greschd force-pushed the feat/582-add-buttjointsequence branch from 1ceaa63 to cfd1142 Compare October 23, 2024 06:36
@greschd greschd linked an issue Oct 23, 2024 that may be closed by this pull request
@greschd greschd force-pushed the feat/582-add-buttjointsequence branch from cfd1142 to ee05fe5 Compare October 23, 2024 11:55
@greschd greschd enabled auto-merge (squash) October 23, 2024 11:56
@greschd greschd force-pushed the feat/582-add-buttjointsequence branch from ee05fe5 to 774123c Compare October 23, 2024 12:29
@greschd greschd merged commit 0dcd834 into main Oct 23, 2024
24 of 26 checks passed
@greschd greschd deleted the feat/582-add-buttjointsequence branch October 23, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ButtJointSequence
2 participants