Skip to content

Commit

Permalink
Fix network-limited benchmarks not running (#627)
Browse files Browse the repository at this point in the history
The benchmarks with specific network latency or bandwidth had failed
to run since the `grpc_server` fixture was renamed to `acp_instance`, 
but the fixture which overrides it in the benchmarks was not.
  • Loading branch information
greschd authored Oct 25, 2024
1 parent 0dcd834 commit dca3001
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/benchmarks/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
BENCHMARK_IMAGE_NAME = "pyacp-benchmark-runner"


def pytest_ignore_collect(collection_path, path, config):
def pytest_ignore_collect(collection_path, config):
# The benchmarks can only be run on Linux, since the 'tc-netem' tool
# used for manipulating network speeds is not available on Docker for
# Windows / Mac.
Expand Down Expand Up @@ -159,5 +159,5 @@ def network_options(request):


@pytest.fixture
def grpc_server(_benchmark_servers, network_options):
def acp_instance(_benchmark_servers, network_options):
return _benchmark_servers[network_options]

0 comments on commit dca3001

Please sign in to comment.