Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add default announcement #161

Merged
merged 25 commits into from
Dec 2, 2022
Merged

Feat: Add default announcement #161

merged 25 commits into from
Dec 2, 2022

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Nov 25, 2022 •
edited
Loading

Add announcement layout, only if announcement file present.
Add layout and styles.

@github-actions github-actions bot added documentation enhancement General improvements to existing features labels Nov 25, 2022
jorgepiloto
jorgepiloto requested changes Nov 28, 2022
View reviewed changes
doc/source/conf.py Outdated Show resolved Hide resolved
src/ansys_sphinx_theme/announcements.html Outdated Show resolved Hide resolved
src/ansys_sphinx_theme/announcement.html Outdated Show resolved Hide resolved
src/ansys_sphinx_theme/layout.html Outdated Show resolved Hide resolved
@jorgepiloto jorgepiloto mentioned this pull request Nov 28, 2022
Merged
@jorgepiloto jorgepiloto force-pushed the feat/modify-annoncement branch 9 times, most recently from 5806e1c to a599d17 Compare November 28, 2022 21:49
@Revathyvenugopal162
Copy link
Contributor Author

https://templates.ansys.com/release/0.1/getting_started/index.html please see the page for check the styles.

@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review November 29, 2022 13:39
jorgepiloto
jorgepiloto requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per private discussion, let us change the announcement color from blue to lightred. Once done, this can be merged.

MaxJPRey
MaxJPRey approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @Revathyvenugopal162 and @jorgepiloto

@jorgepiloto
Copy link
Member

After UX team approval, this can be merged, @Revathyvenugopal162. Feel free to do so.

@Revathyvenugopal162 Revathyvenugopal162 merged commit 1bf7038 into main Dec 2, 2022
@Revathyvenugopal162 Revathyvenugopal162 deleted the feat/modify-annoncement branch December 2, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@jorgepiloto jorgepiloto jorgepiloto approved these changes

Assignees
No one assigned
Labels
enhancement General improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Revathyvenugopal162 @jorgepiloto @MaxJPRey