-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow for missing patch number in tag when deploying docs #653
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
That might be a dumb question but why are we allowing versions that don't follow X.Y.Z template ? |
According to our actions, we were allowing them previously. We can remove this behavior altogether as well, but there's nothing preventing a user from creating a tag "v0.8" and pushing it to PyPI without a patch number. Not ideal, but nothing preventing you from doing it either. We can discuss this further on Thursday if you prefer. |
I don't think I'll be able to join on Thursday (I'm getting back from travel) but that's a subject that should be clarified yeah. I'd rather have no X.Y version and only X.Y.Z versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking the liberty to "block" this PR as long as the dicussion on releasing minor versions is not clarified
Following discussion on dev meeting - tags missing patch number should also be accepted for deploying stable docs since it isn't necessary to have them