-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow GitHub release with no wheels and docs #631
feat: allow GitHub release with no wheels and docs #631
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thansk for the PR @mariostieriansys
Any comments @ansys/pyansys-core? This is a good idea - at least for repos that are consuming our actions and are not actual PyAnsys libs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. The ecosystem has changed quite a lot. I do not see this as an issue on my side.
@jorgepiloto @RobPasMue thanks a lot :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM also :)
Merging! (and releasing right after) |
Released with v8! |
There are repositories where no wheels and/or no docs are generated. Their only aim is just to create a release on github containing the source code.
This PR adds an option to skip the portion of the action where these are gathered, since they are now always expected