Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow GitHub release with no wheels and docs #631

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

mariostieriansys
Copy link
Contributor

There are repositories where no wheels and/or no docs are generated. Their only aim is just to create a release on github containing the source code.

This PR adds an option to skip the portion of the action where these are gathered, since they are now always expected

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement General improvements to existing features label Oct 31, 2024
@mariostieriansys mariostieriansys changed the title Feat/allow GitHub release with no wheels and docs feat: allow GitHub release with no wheels and docs Oct 31, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thansk for the PR @mariostieriansys

Any comments @ansys/pyansys-core? This is a good idea - at least for repos that are consuming our actions and are not actual PyAnsys libs.

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. The ecosystem has changed quite a lot. I do not see this as an issue on my side.

@mariostieriansys
Copy link
Contributor Author

@jorgepiloto @RobPasMue thanks a lot :)
Unfortunately I am not authorized to merge. Could you do it for me? thanks!

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also :)

@RobPasMue
Copy link
Member

Merging! (and releasing right after)

@RobPasMue RobPasMue merged commit 7b4ace9 into main Oct 31, 2024
14 checks passed
@RobPasMue RobPasMue deleted the feat/allow_github_release_with_no_wheels_and_docs branch October 31, 2024 16:01
@RobPasMue
Copy link
Member

Released with v8!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants