fix: exit 1 when logging error messages

[klmcadams]

Add check to see if bot user or email inputs are empty. If so, log an error message & exit 1. Exiting 1 when logging an error message was applied to the _logging action.

Exit 1 on error
Bot secrets exist, so no error

Closes #603

[ansys-reviewer-bot]

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

[germa89]

I think doing exit 1 when we are loggin an error makes sense... however have you checked that you are not logging anywhere else with ERROR level?
Alternatively, you could do that exit optionally using another argument (force_exit maybe?)

Other than that, it looks good to me.

[klmcadams]

It looks like the other locations logging with ERROR are _doc-build-windows and _doc-build-linux when it's unable to determine the PDF filename using the conf.py file. If being unable to determine the PDF filename isn't a dealbreaker & the action can still pass without it, I think the logging level for those cases should change to WARNING instead

[SMoraisAnsys]

LGTM For the doc-build actions I think it's great to have this early exit because if the error logs are triggered, it means that the job using the action will fail fore sure.

[SMoraisAnsys]

It looks like the other locations logging with ERROR are _doc-build-windows and _doc-build-linux when it's unable to determine the PDF filename using the conf.py file. If being unable to determine the PDF filename isn't a dealbreaker & the action can still pass without it, I think the logging level for those cases should change to WARNING instead

It would break further steps in the action if one triggers any of the error log.

[RobPasMue]

LGTM!

[RobPasMue]

Releasing this change