Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove environment from test PyPI #572

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

SMoraisAnsys
Copy link
Contributor

Follow up of #570 which fixed the environment used for test PyPI.
The problem with the fix is that we still end up with messages referring to the deployment in the PR discussion.

image

This PR consists in removing the environment used in test PyPI. Note that:

  • the current environment used (tests) is an empty shell;
  • the previous one (release) shouldn't have been used for testing if we want to keep the protection rules.

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner September 24, 2024 07:31
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Generic maintenance related label Sep 24, 2024
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanks a lot, @SMoraisAnsys

@SMoraisAnsys SMoraisAnsys merged commit 2c02145 into main Sep 24, 2024
16 checks passed
@SMoraisAnsys SMoraisAnsys deleted the ci/remove-environment-in-test-pypi branch September 24, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Generic maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants