Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only compress content inside html folder #507

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

RobPasMue
Copy link
Member

Current Windows implementation was zipping the entire "doc/build..." folder structure. We are only interested in the contents inside the "html" folder

@RobPasMue RobPasMue self-assigned this Jun 17, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner June 17, 2024 07:26
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@RobPasMue
Copy link
Member Author

Requesting specific review from @SMoraisAnsys

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Jun 17, 2024
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for noticing this behavior !
I think we could also use Compress-Archive -Path ${{ env.EXPECTED_BUILD_DIR }}\html\* -DestinationPath documentation-html.zip but you solutions works fine !

@RobPasMue
Copy link
Member Author

LGTM, thanks for noticing this behavior ! I think we could also use Compress-Archive -Path ${{ env.EXPECTED_BUILD_DIR }}\html\* -DestinationPath documentation-html.zip but you solutions works fine !

I tried to be as little invasive as possible with my change - I figured that if you used "zip" directly it was for a reason. Honestly, I'd even delegate all this to the zip action we typically use https://github.com/vimtor/action-zip

@RobPasMue RobPasMue merged commit 4a1a600 into main Jun 17, 2024
16 checks passed
@RobPasMue RobPasMue deleted the fix/only-zip-html-content branch June 17, 2024 09:12
@SMoraisAnsys
Copy link
Contributor

LGTM, thanks for noticing this behavior ! I think we could also use Compress-Archive -Path ${{ env.EXPECTED_BUILD_DIR }}\html\* -DestinationPath documentation-html.zip but you solutions works fine !

I tried to be as little invasive as possible with my change - I figured that if you used "zip" directly it was for a reason. Honestly, I'd even delegate all this to the zip action we typically use https://github.com/vimtor/action-zip

I saw zip being used in other actions and/or repos so I went for it. I would also have used https://github.com/vimtor/action-zip otherwise :')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects or glitches reported by users or developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants